Bdtjtk

I'm doing an API and now I'm consuming with ASP.NET MVC.
I have HomeController.cs, MailController.cs and Services.cs

HomeController

    public async Task<IActionResult> Mirror()

    {

        WeatherService _weather = new WeatherService();

        await _weather.GetMail();

        var a = await _weather.GetWeatherToDay();

        return View(a);

    }

MailController

        [HttpGet]

    public async Task<IEnumerable<MailMessage>> GetEmail()

    {

        try

        {

            var client = new ImapClient("imap.gmail.com", 993, "ACCOUNT", "PASS", AuthMethod.Login, true);                

            var uids = client.Search(SearchCondition.All()).TakeLast(5);

            var msg = client.GetMessages(uids, FetchOptions.HeadersOnly);

            return msg;

        }

        catch (Exception ex)

        {

            throw new Exception(ex.Message);

        }

    }

Services

public async Task<string> GetMail()

    {

        using (HttpClient client = new HttpClient())

        {

            client.BaseAddress = new Uri("https://localhost:44313/api/");

            var response = await client.GetAsync("mail");

            var responseToString = await response.Content.ReadAsStringAsync();

            return responseToString;

        }

    }

Yes I know that my code it could be better...
I think that the problem is in the awaiters because when try to save result on variable response from Services get error and the executions it's continue... but without value.

Thanks! :)

MailController.GetEmail does not await anything.

I suggest you you refactor if no Task is needed

[HttpGet]

public IActionResult GetEmail() {

    var client = new ImapClient("imap.gmail.com", 993, "ACCOUNT", "PASS", AuthMethod.Login, true);                

    var uids = client.Search(SearchCondition.All()).TakeLast(5);

    var msgs = client.GetMessages(uids, FetchOptions.HeadersOnly);//IEnumerable<MailMessage>

    return Ok(msgs);

}

Also the calling code for Mirror is not assigning a value;

//...

var data = await _weather.GetMail();

//...

I think you haven't use HttpResponseMessage in the service.

public async Task<string> GetMail() {

    HttpClient client = new HttpClient();

    client.BaseAddress = new Uri("https://localhost:44313/api/");

    using (HttpResponseMessage response = await client.GetAsync("mail")) {

        if (response.IsSuccessStatusCode) {

            var responseToString = await response.Content.ReadAsStringAsync();

            return responseToString;

        }

    }

}