When using Sequelize transactions with async await is it OK to return a promise?
Assume that I have a table called Item with a field called "name". There is a unique key constraint on the name field. Why would these two functions behave differently when calling them with await? The only difference is that one awaits before destroying the item, while the other returns the promise of destruction. Shouldn't these uses be identical?
const createAndDestroyWorksFine = async (name) => {
await Item.create({ name })
const item = await Item.findOne({ where: { name } });
await item.destroy();
}
const createAndDestroyCausesError = async (name) => {
await Item.create({ name })
const item = await Item.findOne({ where: { name } });
return item.destroy();
}
async function test() {
// this works
await transaction(createAndDestroyWorksFine('item'));
await transaction(createAndDestroyWorksFine('item'));
// this fails often, with a duplicate key error
await transaction(createAndDestroyCausesError('item'));
await transaction(createAndDestroyCausesError('item'));
}
test()
transactions async-await sequelize.js
asked Dec 28 '18 at 16:21
DaveDave
8211118
add a comment |
Assume that I have a table called Item with a field called "name". There is a unique key constraint on the name field. Why would these two functions behave differently when calling them with await? The only difference is that one awaits before destroying the item, while the other returns the promise of destruction. Shouldn't these uses be identical?
const createAndDestroyWorksFine = async (name) => {
await Item.create({ name })
const item = await Item.findOne({ where: { name } });
await item.destroy();
}
const createAndDestroyCausesError = async (name) => {
await Item.create({ name })
const item = await Item.findOne({ where: { name } });
return item.destroy();
}
async function test() {
// this works
await transaction(createAndDestroyWorksFine('item'));
await transaction(createAndDestroyWorksFine('item'));
// this fails often, with a duplicate key error
await transaction(createAndDestroyCausesError('item'));
await transaction(createAndDestroyCausesError('item'));
}
test()
transactions async-await sequelize.js
asked Dec 28 '18 at 16:21
DaveDave
8211118
add a comment |
Assume that I have a table called Item with a field called "name". There is a unique key constraint on the name field. Why would these two functions behave differently when calling them with await? The only difference is that one awaits before destroying the item, while the other returns the promise of destruction. Shouldn't these uses be identical?
const createAndDestroyWorksFine = async (name) => {
await Item.create({ name })
const item = await Item.findOne({ where: { name } });
await item.destroy();
}
const createAndDestroyCausesError = async (name) => {
await Item.create({ name })
const item = await Item.findOne({ where: { name } });
return item.destroy();
}
async function test() {
// this works
await transaction(createAndDestroyWorksFine('item'));
await transaction(createAndDestroyWorksFine('item'));
// this fails often, with a duplicate key error
await transaction(createAndDestroyCausesError('item'));
await transaction(createAndDestroyCausesError('item'));
}
test()
transactions async-await sequelize.js
asked Dec 28 '18 at 16:21
DaveDave
8211118
Assume that I have a table called Item with a field called "name". There is a unique key constraint on the name field. Why would these two functions behave differently when calling them with await? The only difference is that one awaits before destroying the item, while the other returns the promise of destruction. Shouldn't these uses be identical?
const createAndDestroyWorksFine = async (name) => {
await Item.create({ name })
const item = await Item.findOne({ where: { name } });
await item.destroy();
}
const createAndDestroyCausesError = async (name) => {
await Item.create({ name })
const item = await Item.findOne({ where: { name } });
return item.destroy();
}
async function test() {
// this works
await transaction(createAndDestroyWorksFine('item'));
await transaction(createAndDestroyWorksFine('item'));
// this fails often, with a duplicate key error
await transaction(createAndDestroyCausesError('item'));
await transaction(createAndDestroyCausesError('item'));
}
test()
transactions async-await sequelize.js
transactions async-await sequelize.js
asked Dec 28 '18 at 16:21
DaveDave
8211118
asked Dec 28 '18 at 16:21
DaveDave
8211118
asked Dec 28 '18 at 16:21
DaveDave
8211118
asked Dec 28 '18 at 16:21
DaveDave
8211118
asked Dec 28 '18 at 16:21
DaveDave
8211118
8211118
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53961387%2fwhen-using-sequelize-transactions-with-async-await-is-it-ok-to-return-a-promise%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53961387%2fwhen-using-sequelize-transactions-with-async-await-is-it-ok-to-return-a-promise%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
