React SSR two pass rendering with renderToString and renderToNodeStream

Multi tool use
I'm trying to do SSR with ReactDOMServer.renderToNodeStream(element)
but just wanted to know if there would be any problem with using both ReactDOMServer.renderToString(element)
and ReactDOMServer.renderToNodeStream(element)
at each request?
What I have in my custom SSR setup is:
* React 16
* react-loadable
* styled-components v4
* react-helmet-async
* Redux
* Express JS
Previously with React, I could easily render a HTML document by first rendering the <head></head>
tags that contains markup produced by react-helmet
and then using ReactDOMServer.renderToString()
to render my React elements.
However, by switching to ReactDOMServer.renderToNodeStream()
I had to switch react-helmet
for react-helmet-async
, which supports renderToNodeStream()
function. But then when I try to render the <head></head>
tags with the markup by react-helmet-async
it'll come back as undefined
.
To get around this problem, I've had to use renderToString()
first without actually writing that out to Express JS response
. That way react-helmet-async
can then see what meta tags to render and then proceed to use renderToNodeStream
and stream that out to the response
.
I've simplified my code as much as possible as I want to understand if this would have a negative impact (for performance, or if anyone can think of anything else)?
Before:
let html = ReactDOMServer.renderToString(stylesheet.collectStyles(
<Loadable.Capture report={moduleName => modules.push(moduleName)}>
<LocalStoreProvider store={store}>
<HelmetProvider context={helmetContext}>
<RouterContext {...renderProps} />
</HelmetProvider>
</LocalStoreProvider>
</Loadable.Capture>
));
const { helmet } = helmetContext;
response.write(
renderDocumentHead({
css: stylesheet.getStyleTags(),
title: helmet.title.toString(),
link: helmet.link.toString(),
meta: helmet.meta.toString()
})
);
response.write(html);
After:
let html = stylesheet.collectStyles(
<Loadable.Capture report={moduleName => modules.push(moduleName)}>
<LocalStoreProvider store={store}>
<HelmetProvider context={helmetContext}>
<RouterContext {...renderProps} />
</HelmetProvider>
</LocalStoreProvider>
</Loadable.Capture>
);
// do a first pass render so that react-helmet-async
// can see what meta tags to render
ReactDOMServer.renderToString(html);
const { helmet } = helmetContext;
response.write(
renderDocumentHead({
css: stylesheet.getStyleTags(),
title: helmet.title.toString(),
link: helmet.link.toString(),
meta: helmet.meta.toString()
})
);
const stream = stylesheet.interleaveWithNodeStream(
ReactDOMServer.renderToNodeStream(html)
);
// and then actually stream the react elements out
stream.pipe(response, { end: false });
stream.on('end', () => response.end('</body></html>'));
Unfortunately, the only way I could get react-helmet-async
to work correctly, I have to do this two-pass render. My CSS styles, etc. resolves correctly and the client renders/hydrates correctly too. I've seen other examples where react-apollo
was used and the getDataFromTree
data rehydration method was used which allows react-helmet-async
to see what was needed to render the head markup. But hopefully there are no issues with my two-pass rendering approach?
javascript reactjs styled-components ssr react-helmet
add a comment |
I'm trying to do SSR with ReactDOMServer.renderToNodeStream(element)
but just wanted to know if there would be any problem with using both ReactDOMServer.renderToString(element)
and ReactDOMServer.renderToNodeStream(element)
at each request?
What I have in my custom SSR setup is:
* React 16
* react-loadable
* styled-components v4
* react-helmet-async
* Redux
* Express JS
Previously with React, I could easily render a HTML document by first rendering the <head></head>
tags that contains markup produced by react-helmet
and then using ReactDOMServer.renderToString()
to render my React elements.
However, by switching to ReactDOMServer.renderToNodeStream()
I had to switch react-helmet
for react-helmet-async
, which supports renderToNodeStream()
function. But then when I try to render the <head></head>
tags with the markup by react-helmet-async
it'll come back as undefined
.
To get around this problem, I've had to use renderToString()
first without actually writing that out to Express JS response
. That way react-helmet-async
can then see what meta tags to render and then proceed to use renderToNodeStream
and stream that out to the response
.
I've simplified my code as much as possible as I want to understand if this would have a negative impact (for performance, or if anyone can think of anything else)?
Before:
let html = ReactDOMServer.renderToString(stylesheet.collectStyles(
<Loadable.Capture report={moduleName => modules.push(moduleName)}>
<LocalStoreProvider store={store}>
<HelmetProvider context={helmetContext}>
<RouterContext {...renderProps} />
</HelmetProvider>
</LocalStoreProvider>
</Loadable.Capture>
));
const { helmet } = helmetContext;
response.write(
renderDocumentHead({
css: stylesheet.getStyleTags(),
title: helmet.title.toString(),
link: helmet.link.toString(),
meta: helmet.meta.toString()
})
);
response.write(html);
After:
let html = stylesheet.collectStyles(
<Loadable.Capture report={moduleName => modules.push(moduleName)}>
<LocalStoreProvider store={store}>
<HelmetProvider context={helmetContext}>
<RouterContext {...renderProps} />
</HelmetProvider>
</LocalStoreProvider>
</Loadable.Capture>
);
// do a first pass render so that react-helmet-async
// can see what meta tags to render
ReactDOMServer.renderToString(html);
const { helmet } = helmetContext;
response.write(
renderDocumentHead({
css: stylesheet.getStyleTags(),
title: helmet.title.toString(),
link: helmet.link.toString(),
meta: helmet.meta.toString()
})
);
const stream = stylesheet.interleaveWithNodeStream(
ReactDOMServer.renderToNodeStream(html)
);
// and then actually stream the react elements out
stream.pipe(response, { end: false });
stream.on('end', () => response.end('</body></html>'));
Unfortunately, the only way I could get react-helmet-async
to work correctly, I have to do this two-pass render. My CSS styles, etc. resolves correctly and the client renders/hydrates correctly too. I've seen other examples where react-apollo
was used and the getDataFromTree
data rehydration method was used which allows react-helmet-async
to see what was needed to render the head markup. But hopefully there are no issues with my two-pass rendering approach?
javascript reactjs styled-components ssr react-helmet
I arrived at the same conclusion. I tried usingreact-tree-walker
to have a cheaper option but couldn't get it to work. Tried a number of scenarios
– Marc
Jan 22 at 16:47
Yeah I think I've come to the conclusion that there's no issues with doing this as it's just running a function, not storing it anywhere or outputting via the response. I few other resources also mention a two pass render to make this work. I think if your custom SSR approach allows for this then this is a possible solution.
– S. Luong
Jan 23 at 22:07
add a comment |
I'm trying to do SSR with ReactDOMServer.renderToNodeStream(element)
but just wanted to know if there would be any problem with using both ReactDOMServer.renderToString(element)
and ReactDOMServer.renderToNodeStream(element)
at each request?
What I have in my custom SSR setup is:
* React 16
* react-loadable
* styled-components v4
* react-helmet-async
* Redux
* Express JS
Previously with React, I could easily render a HTML document by first rendering the <head></head>
tags that contains markup produced by react-helmet
and then using ReactDOMServer.renderToString()
to render my React elements.
However, by switching to ReactDOMServer.renderToNodeStream()
I had to switch react-helmet
for react-helmet-async
, which supports renderToNodeStream()
function. But then when I try to render the <head></head>
tags with the markup by react-helmet-async
it'll come back as undefined
.
To get around this problem, I've had to use renderToString()
first without actually writing that out to Express JS response
. That way react-helmet-async
can then see what meta tags to render and then proceed to use renderToNodeStream
and stream that out to the response
.
I've simplified my code as much as possible as I want to understand if this would have a negative impact (for performance, or if anyone can think of anything else)?
Before:
let html = ReactDOMServer.renderToString(stylesheet.collectStyles(
<Loadable.Capture report={moduleName => modules.push(moduleName)}>
<LocalStoreProvider store={store}>
<HelmetProvider context={helmetContext}>
<RouterContext {...renderProps} />
</HelmetProvider>
</LocalStoreProvider>
</Loadable.Capture>
));
const { helmet } = helmetContext;
response.write(
renderDocumentHead({
css: stylesheet.getStyleTags(),
title: helmet.title.toString(),
link: helmet.link.toString(),
meta: helmet.meta.toString()
})
);
response.write(html);
After:
let html = stylesheet.collectStyles(
<Loadable.Capture report={moduleName => modules.push(moduleName)}>
<LocalStoreProvider store={store}>
<HelmetProvider context={helmetContext}>
<RouterContext {...renderProps} />
</HelmetProvider>
</LocalStoreProvider>
</Loadable.Capture>
);
// do a first pass render so that react-helmet-async
// can see what meta tags to render
ReactDOMServer.renderToString(html);
const { helmet } = helmetContext;
response.write(
renderDocumentHead({
css: stylesheet.getStyleTags(),
title: helmet.title.toString(),
link: helmet.link.toString(),
meta: helmet.meta.toString()
})
);
const stream = stylesheet.interleaveWithNodeStream(
ReactDOMServer.renderToNodeStream(html)
);
// and then actually stream the react elements out
stream.pipe(response, { end: false });
stream.on('end', () => response.end('</body></html>'));
Unfortunately, the only way I could get react-helmet-async
to work correctly, I have to do this two-pass render. My CSS styles, etc. resolves correctly and the client renders/hydrates correctly too. I've seen other examples where react-apollo
was used and the getDataFromTree
data rehydration method was used which allows react-helmet-async
to see what was needed to render the head markup. But hopefully there are no issues with my two-pass rendering approach?
javascript reactjs styled-components ssr react-helmet
I'm trying to do SSR with ReactDOMServer.renderToNodeStream(element)
but just wanted to know if there would be any problem with using both ReactDOMServer.renderToString(element)
and ReactDOMServer.renderToNodeStream(element)
at each request?
What I have in my custom SSR setup is:
* React 16
* react-loadable
* styled-components v4
* react-helmet-async
* Redux
* Express JS
Previously with React, I could easily render a HTML document by first rendering the <head></head>
tags that contains markup produced by react-helmet
and then using ReactDOMServer.renderToString()
to render my React elements.
However, by switching to ReactDOMServer.renderToNodeStream()
I had to switch react-helmet
for react-helmet-async
, which supports renderToNodeStream()
function. But then when I try to render the <head></head>
tags with the markup by react-helmet-async
it'll come back as undefined
.
To get around this problem, I've had to use renderToString()
first without actually writing that out to Express JS response
. That way react-helmet-async
can then see what meta tags to render and then proceed to use renderToNodeStream
and stream that out to the response
.
I've simplified my code as much as possible as I want to understand if this would have a negative impact (for performance, or if anyone can think of anything else)?
Before:
let html = ReactDOMServer.renderToString(stylesheet.collectStyles(
<Loadable.Capture report={moduleName => modules.push(moduleName)}>
<LocalStoreProvider store={store}>
<HelmetProvider context={helmetContext}>
<RouterContext {...renderProps} />
</HelmetProvider>
</LocalStoreProvider>
</Loadable.Capture>
));
const { helmet } = helmetContext;
response.write(
renderDocumentHead({
css: stylesheet.getStyleTags(),
title: helmet.title.toString(),
link: helmet.link.toString(),
meta: helmet.meta.toString()
})
);
response.write(html);
After:
let html = stylesheet.collectStyles(
<Loadable.Capture report={moduleName => modules.push(moduleName)}>
<LocalStoreProvider store={store}>
<HelmetProvider context={helmetContext}>
<RouterContext {...renderProps} />
</HelmetProvider>
</LocalStoreProvider>
</Loadable.Capture>
);
// do a first pass render so that react-helmet-async
// can see what meta tags to render
ReactDOMServer.renderToString(html);
const { helmet } = helmetContext;
response.write(
renderDocumentHead({
css: stylesheet.getStyleTags(),
title: helmet.title.toString(),
link: helmet.link.toString(),
meta: helmet.meta.toString()
})
);
const stream = stylesheet.interleaveWithNodeStream(
ReactDOMServer.renderToNodeStream(html)
);
// and then actually stream the react elements out
stream.pipe(response, { end: false });
stream.on('end', () => response.end('</body></html>'));
Unfortunately, the only way I could get react-helmet-async
to work correctly, I have to do this two-pass render. My CSS styles, etc. resolves correctly and the client renders/hydrates correctly too. I've seen other examples where react-apollo
was used and the getDataFromTree
data rehydration method was used which allows react-helmet-async
to see what was needed to render the head markup. But hopefully there are no issues with my two-pass rendering approach?
javascript reactjs styled-components ssr react-helmet
javascript reactjs styled-components ssr react-helmet
asked Jan 2 at 16:00
S. LuongS. Luong
614
614
I arrived at the same conclusion. I tried usingreact-tree-walker
to have a cheaper option but couldn't get it to work. Tried a number of scenarios
– Marc
Jan 22 at 16:47
Yeah I think I've come to the conclusion that there's no issues with doing this as it's just running a function, not storing it anywhere or outputting via the response. I few other resources also mention a two pass render to make this work. I think if your custom SSR approach allows for this then this is a possible solution.
– S. Luong
Jan 23 at 22:07
add a comment |
I arrived at the same conclusion. I tried usingreact-tree-walker
to have a cheaper option but couldn't get it to work. Tried a number of scenarios
– Marc
Jan 22 at 16:47
Yeah I think I've come to the conclusion that there's no issues with doing this as it's just running a function, not storing it anywhere or outputting via the response. I few other resources also mention a two pass render to make this work. I think if your custom SSR approach allows for this then this is a possible solution.
– S. Luong
Jan 23 at 22:07
I arrived at the same conclusion. I tried using
react-tree-walker
to have a cheaper option but couldn't get it to work. Tried a number of scenarios– Marc
Jan 22 at 16:47
I arrived at the same conclusion. I tried using
react-tree-walker
to have a cheaper option but couldn't get it to work. Tried a number of scenarios– Marc
Jan 22 at 16:47
Yeah I think I've come to the conclusion that there's no issues with doing this as it's just running a function, not storing it anywhere or outputting via the response. I few other resources also mention a two pass render to make this work. I think if your custom SSR approach allows for this then this is a possible solution.
– S. Luong
Jan 23 at 22:07
Yeah I think I've come to the conclusion that there's no issues with doing this as it's just running a function, not storing it anywhere or outputting via the response. I few other resources also mention a two pass render to make this work. I think if your custom SSR approach allows for this then this is a possible solution.
– S. Luong
Jan 23 at 22:07
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54009409%2freact-ssr-two-pass-rendering-with-rendertostring-and-rendertonodestream%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54009409%2freact-ssr-two-pass-rendering-with-rendertostring-and-rendertonodestream%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
E0a0r7,gUop,RO6sScIt,mBZTLESOcQKZqAb1BBM3qHy f,k,A qs0TAegqQYTtZO
I arrived at the same conclusion. I tried using
react-tree-walker
to have a cheaper option but couldn't get it to work. Tried a number of scenarios– Marc
Jan 22 at 16:47
Yeah I think I've come to the conclusion that there's no issues with doing this as it's just running a function, not storing it anywhere or outputting via the response. I few other resources also mention a two pass render to make this work. I think if your custom SSR approach allows for this then this is a possible solution.
– S. Luong
Jan 23 at 22:07