Bdtjtk

I have a list of ObjectGUID's (49 of them) stored in a CSV, and I'm outputting a CSV which contains a listing of all members of those groups in the following format: "LastName, FirstName" , "AD Group Name"
I have it working (most of the time; sometimes I get IOException errors from the Add-Content cmdlt), but it is very slow (takes ~30 minutes for 8000 members). I don't have a lot of experience with Powershell , but I feel like there is a better/more efficient way of doing this. Any ideas on how to make this more efficient?

Note: I use the "-Server" switch because I actually have to run this script across a couple different domains, so the code I've pasted is duplicated twice in my original code, with a different CSV input, and a different domain passed to the "-Server" switch.

#read in CSV of ObjectGUIDs

$guids = Import-CSV .ObjectGUIDs.csv



#loop through each AD group

foreach($group in $guids) {

    $group_name = Get-ADObject -identity $group.objectGUID -server myDomain

    $group_name = $group_name.Name



    #get list of users in current group

    $users = get-adgroupmember  -server myDomain -identity 

             $group.ObjectGUID | where {$_.objectclass -eq 'user'}



    #loop through each user of the current group

    foreach ($user in $users) {

        #get display name of current user

        $display_name = get-aduser -identity $user.objectGUID -server 

                        myDomain -properties DisplayName

        #build the current row

        $row =  ('"' + $display_name.DisplayName + '"' + ',' + '"' + 

                 $group_name + '"')

        add-content -path "C:Pathtooutput.csv"  -value $row

    }

}

As I said above, this usually works, but takes a long time.

Gathering data in a [PSCustomObject] and using Export-Csv only once should be much more efficient.

## Q:Test20181227SO_53946702.ps1



$guids = Import-CSV .ObjectGUIDs.csv

$CsvFile = "C:Pathtooutput.csv"

$Server = myDomain



$CsvData = foreach($group in $guids) {

    $GroupName = (Get-ADObject -identity $group.objectGUID -server $Server).Name



    #get list of users in current group

    $users = Get-ADgroupMember  -Server $Server -Identity $group.ObjectGUID |

              Where-Object ObjectClass -eq 'user'



    foreach ($user in $users) {

        [PSCustomObject]@{

            DisplayName = (Get-ADuser -Identity $user.objectGUID -server $Server -Properties DisplayName).DisplayName

            GroupName   = $GroupName

        }

    }

}

$CsvData | Export-Csv $CsvFile -NoTypeInformation