React component not rendering correctly
0
I have a react component that grabs image urls from a service. I take these urls and just create some <img .../> elements to show the images.
There is 1 image list per row. This works on the initial load, but when I start removing rows (done by splicing the element out of the global state's array, handled by redux), the row is deleted correctly, but the images don't change. It seems that each row's images will "leak" over.
Here's a screencap:
I'm thinking I need to force a re-render somewhere, maybe at the parent level?
Here's my container code:
class SourceMediaPreviewContainer extends Component {
constructor(props) {
super(props);
this.state = {
source: {},
media: ,
};
}
async componentDidMount() {
const { source: _source } = this.props;
const { data } = (await this.getMedia({ source: _source })) || {};
const { media = , ...source } = data || {};
this.setState({ source, media });
}
async getMedia({ source }) {
return describeSourceMedia({ source });
}
render() {
return (
<div className="asb-source-media-preview">
{this.state.media.map((media, i) => (
<img
key={media.url}
className="asb-source-media-preview__img"
src={media.media_url}
alt={media.title}
/>
))}
</div>
);
}
}
const mapStateToProps = (state) => ({
// mediaSource: state.asb.mediaSource,
});
const mapDispatchToProps = (dispatch) =>
bindActionCreators(
{
// ...mediaSourceOperations,
},
dispatch,
);
export default connect(
mapStateToProps,
mapDispatchToProps,
)(SourceMediaPreviewContainer);
javascript html reactjs react-redux render
asked Jan 2 at 0:47
PGTPGT
413420
|
show 3 more comments
0
I have a react component that grabs image urls from a service. I take these urls and just create some <img .../> elements to show the images.
There is 1 image list per row. This works on the initial load, but when I start removing rows (done by splicing the element out of the global state's array, handled by redux), the row is deleted correctly, but the images don't change. It seems that each row's images will "leak" over.
Here's a screencap:
I'm thinking I need to force a re-render somewhere, maybe at the parent level?
Here's my container code:
class SourceMediaPreviewContainer extends Component {
constructor(props) {
super(props);
this.state = {
source: {},
media: ,
};
}
async componentDidMount() {
const { source: _source } = this.props;
const { data } = (await this.getMedia({ source: _source })) || {};
const { media = , ...source } = data || {};
this.setState({ source, media });
}
async getMedia({ source }) {
return describeSourceMedia({ source });
}
render() {
return (
<div className="asb-source-media-preview">
{this.state.media.map((media, i) => (
<img
key={media.url}
className="asb-source-media-preview__img"
src={media.media_url}
alt={media.title}
/>
))}
</div>
);
}
}
const mapStateToProps = (state) => ({
// mediaSource: state.asb.mediaSource,
});
const mapDispatchToProps = (dispatch) =>
bindActionCreators(
{
// ...mediaSourceOperations,
},
dispatch,
);
export default connect(
mapStateToProps,
mapDispatchToProps,
)(SourceMediaPreviewContainer);
javascript html reactjs react-redux render
asked Jan 2 at 0:47
PGTPGT
413420
what is themediaSourceprop passed from the state? It looks like you never use it inside your component
– quirimmo
Jan 2 at 1:04
What does delete row function like? And, try key={media.media_url}.
– chendesheng
Jan 2 at 1:05
@quirimmo: This is unused and requires cleanup.
– PGT
Jan 2 at 1:05
and how do you notify to the component that the image has been removed? React renders again only if props or internal state changed
– quirimmo
Jan 2 at 1:07
@quirimmo: when the item is sliced out of the array, redux informs react that the state has changed and requires a render. You can see this working correctly as the words associated with the removed row disappears, what's weird is that the images don't render correctly
– PGT
Jan 2 at 1:09
|
show 3 more comments
0
0
0
I have a react component that grabs image urls from a service. I take these urls and just create some <img .../> elements to show the images.
There is 1 image list per row. This works on the initial load, but when I start removing rows (done by splicing the element out of the global state's array, handled by redux), the row is deleted correctly, but the images don't change. It seems that each row's images will "leak" over.
Here's a screencap:
I'm thinking I need to force a re-render somewhere, maybe at the parent level?
Here's my container code:
class SourceMediaPreviewContainer extends Component {
constructor(props) {
super(props);
this.state = {
source: {},
media: ,
};
}
async componentDidMount() {
const { source: _source } = this.props;
const { data } = (await this.getMedia({ source: _source })) || {};
const { media = , ...source } = data || {};
this.setState({ source, media });
}
async getMedia({ source }) {
return describeSourceMedia({ source });
}
render() {
return (
<div className="asb-source-media-preview">
{this.state.media.map((media, i) => (
<img
key={media.url}
className="asb-source-media-preview__img"
src={media.media_url}
alt={media.title}
/>
))}
</div>
);
}
}
const mapStateToProps = (state) => ({
// mediaSource: state.asb.mediaSource,
});
const mapDispatchToProps = (dispatch) =>
bindActionCreators(
{
// ...mediaSourceOperations,
},
dispatch,
);
export default connect(
mapStateToProps,
mapDispatchToProps,
)(SourceMediaPreviewContainer);
javascript html reactjs react-redux render
asked Jan 2 at 0:47
PGTPGT
413420
I have a react component that grabs image urls from a service. I take these urls and just create some <img .../> elements to show the images.
There is 1 image list per row. This works on the initial load, but when I start removing rows (done by splicing the element out of the global state's array, handled by redux), the row is deleted correctly, but the images don't change. It seems that each row's images will "leak" over.
Here's a screencap:
I'm thinking I need to force a re-render somewhere, maybe at the parent level?
Here's my container code:
class SourceMediaPreviewContainer extends Component {
constructor(props) {
super(props);
this.state = {
source: {},
media: ,
};
}
async componentDidMount() {
const { source: _source } = this.props;
const { data } = (await this.getMedia({ source: _source })) || {};
const { media = , ...source } = data || {};
this.setState({ source, media });
}
async getMedia({ source }) {
return describeSourceMedia({ source });
}
render() {
return (
<div className="asb-source-media-preview">
{this.state.media.map((media, i) => (
<img
key={media.url}
className="asb-source-media-preview__img"
src={media.media_url}
alt={media.title}
/>
))}
</div>
);
}
}
const mapStateToProps = (state) => ({
// mediaSource: state.asb.mediaSource,
});
const mapDispatchToProps = (dispatch) =>
bindActionCreators(
{
// ...mediaSourceOperations,
},
dispatch,
);
export default connect(
mapStateToProps,
mapDispatchToProps,
)(SourceMediaPreviewContainer);
javascript html reactjs react-redux render
javascript html reactjs react-redux render
asked Jan 2 at 0:47
PGTPGT
413420
asked Jan 2 at 0:47
PGTPGT
413420
edited Jan 2 at 3:18
PGT
asked Jan 2 at 0:47
PGTPGT
413420
asked Jan 2 at 0:47
PGTPGT
413420
asked Jan 2 at 0:47
PGTPGT
413420
413420
what is themediaSourceprop passed from the state? It looks like you never use it inside your component
– quirimmo
Jan 2 at 1:04
What does delete row function like? And, try key={media.media_url}.
– chendesheng
Jan 2 at 1:05
@quirimmo: This is unused and requires cleanup.
– PGT
Jan 2 at 1:05
and how do you notify to the component that the image has been removed? React renders again only if props or internal state changed
– quirimmo
Jan 2 at 1:07
@quirimmo: when the item is sliced out of the array, redux informs react that the state has changed and requires a render. You can see this working correctly as the words associated with the removed row disappears, what's weird is that the images don't render correctly
– PGT
Jan 2 at 1:09
|
show 3 more comments
what is themediaSourceprop passed from the state? It looks like you never use it inside your component
– quirimmo
Jan 2 at 1:04
What does delete row function like? And, try key={media.media_url}.
– chendesheng
Jan 2 at 1:05
@quirimmo: This is unused and requires cleanup.
– PGT
Jan 2 at 1:05
and how do you notify to the component that the image has been removed? React renders again only if props or internal state changed
– quirimmo
Jan 2 at 1:07
@quirimmo: when the item is sliced out of the array, redux informs react that the state has changed and requires a render. You can see this working correctly as the words associated with the removed row disappears, what's weird is that the images don't render correctly
– PGT
Jan 2 at 1:09
what is the
mediaSource prop passed from the state? It looks like you never use it inside your component– quirimmo
Jan 2 at 1:04
what is the
mediaSource prop passed from the state? It looks like you never use it inside your component– quirimmo
Jan 2 at 1:04
What does delete row function like? And, try key={media.media_url}.
– chendesheng
Jan 2 at 1:05
What does delete row function like? And, try key={media.media_url}.
– chendesheng
Jan 2 at 1:05
@quirimmo: This is unused and requires cleanup.
– PGT
Jan 2 at 1:05
@quirimmo: This is unused and requires cleanup.
– PGT
Jan 2 at 1:05
and how do you notify to the component that the image has been removed? React renders again only if props or internal state changed
– quirimmo
Jan 2 at 1:07
and how do you notify to the component that the image has been removed? React renders again only if props or internal state changed
– quirimmo
Jan 2 at 1:07
@quirimmo: when the item is sliced out of the array, redux informs react that the state has changed and requires a render. You can see this working correctly as the words associated with the removed row disappears, what's weird is that the images don't render correctly
– PGT
Jan 2 at 1:09
@quirimmo: when the item is sliced out of the array, redux informs react that the state has changed and requires a render. You can see this working correctly as the words associated with the removed row disappears, what's weird is that the images don't render correctly
– PGT
Jan 2 at 1:09
|
show 3 more comments
0
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54000103%2freact-component-not-rendering-correctly%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54000103%2freact-component-not-rendering-correctly%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
what is the
mediaSourceprop passed from the state? It looks like you never use it inside your component– quirimmo
Jan 2 at 1:04
What does delete row function like? And, try key={media.media_url}.
– chendesheng
Jan 2 at 1:05
@quirimmo: This is unused and requires cleanup.
– PGT
Jan 2 at 1:05
and how do you notify to the component that the image has been removed? React renders again only if props or internal state changed
– quirimmo
Jan 2 at 1:07
@quirimmo: when the item is sliced out of the array, redux informs react that the state has changed and requires a render. You can see this working correctly as the words associated with the removed row disappears, what's weird is that the images don't render correctly
– PGT
Jan 2 at 1:09