Time complexity of this code (from Cracking the Coding Interview “Group Anagrams”)

Multi tool use
Multi tool use












0














The author claims the following code to be O(n * log(n)). This seems to imply that the Comparator is doing constant-time work, but there's a sort embedded in the Comparator's compare() function. Doesn't this increase the time complexity?



class AnagramComparator implements Comparator<String> {
public String sortChars(String s) {
char content = s.toCharArray();
Array.sort(content);
return new String(content);
}

public int compare(String s1, String s2) {
return sortChars(s1).compareTo(sortChars(s2));
}
}

Arrays.sort(array, new AnagramComparator());









share|improve this question


















  • 1




    The embedded sort call's time complexity depends on the lengths of the strings, not the number of strings (n). The author has probably assumed this to be small.
    – meowgoesthedog
    Dec 28 '18 at 9:23










  • So, if we call the size of the biggest string s, and assume s << n, we can disregard the embedded sort's time complexity of O(n * s * log(s)) because O(n * log(n)) is the dominant term?
    – UnknownBeef
    Dec 28 '18 at 18:41










  • Are you referring to line 4? If so, since we are sorting an array of size s, isn't that an O(s * log(s)) operation each time?
    – UnknownBeef
    Dec 29 '18 at 6:07










  • I meant that O(n * log(n) * s * log(s)) = O(n * s * log(n)), not O(n * s * log(s)).
    – meowgoesthedog
    Dec 29 '18 at 9:37
















0














The author claims the following code to be O(n * log(n)). This seems to imply that the Comparator is doing constant-time work, but there's a sort embedded in the Comparator's compare() function. Doesn't this increase the time complexity?



class AnagramComparator implements Comparator<String> {
public String sortChars(String s) {
char content = s.toCharArray();
Array.sort(content);
return new String(content);
}

public int compare(String s1, String s2) {
return sortChars(s1).compareTo(sortChars(s2));
}
}

Arrays.sort(array, new AnagramComparator());









share|improve this question


















  • 1




    The embedded sort call's time complexity depends on the lengths of the strings, not the number of strings (n). The author has probably assumed this to be small.
    – meowgoesthedog
    Dec 28 '18 at 9:23










  • So, if we call the size of the biggest string s, and assume s << n, we can disregard the embedded sort's time complexity of O(n * s * log(s)) because O(n * log(n)) is the dominant term?
    – UnknownBeef
    Dec 28 '18 at 18:41










  • Are you referring to line 4? If so, since we are sorting an array of size s, isn't that an O(s * log(s)) operation each time?
    – UnknownBeef
    Dec 29 '18 at 6:07










  • I meant that O(n * log(n) * s * log(s)) = O(n * s * log(n)), not O(n * s * log(s)).
    – meowgoesthedog
    Dec 29 '18 at 9:37














0












0








0







The author claims the following code to be O(n * log(n)). This seems to imply that the Comparator is doing constant-time work, but there's a sort embedded in the Comparator's compare() function. Doesn't this increase the time complexity?



class AnagramComparator implements Comparator<String> {
public String sortChars(String s) {
char content = s.toCharArray();
Array.sort(content);
return new String(content);
}

public int compare(String s1, String s2) {
return sortChars(s1).compareTo(sortChars(s2));
}
}

Arrays.sort(array, new AnagramComparator());









share|improve this question













The author claims the following code to be O(n * log(n)). This seems to imply that the Comparator is doing constant-time work, but there's a sort embedded in the Comparator's compare() function. Doesn't this increase the time complexity?



class AnagramComparator implements Comparator<String> {
public String sortChars(String s) {
char content = s.toCharArray();
Array.sort(content);
return new String(content);
}

public int compare(String s1, String s2) {
return sortChars(s1).compareTo(sortChars(s2));
}
}

Arrays.sort(array, new AnagramComparator());






big-o






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Dec 28 '18 at 3:03









UnknownBeef

306




306








  • 1




    The embedded sort call's time complexity depends on the lengths of the strings, not the number of strings (n). The author has probably assumed this to be small.
    – meowgoesthedog
    Dec 28 '18 at 9:23










  • So, if we call the size of the biggest string s, and assume s << n, we can disregard the embedded sort's time complexity of O(n * s * log(s)) because O(n * log(n)) is the dominant term?
    – UnknownBeef
    Dec 28 '18 at 18:41










  • Are you referring to line 4? If so, since we are sorting an array of size s, isn't that an O(s * log(s)) operation each time?
    – UnknownBeef
    Dec 29 '18 at 6:07










  • I meant that O(n * log(n) * s * log(s)) = O(n * s * log(n)), not O(n * s * log(s)).
    – meowgoesthedog
    Dec 29 '18 at 9:37














  • 1




    The embedded sort call's time complexity depends on the lengths of the strings, not the number of strings (n). The author has probably assumed this to be small.
    – meowgoesthedog
    Dec 28 '18 at 9:23










  • So, if we call the size of the biggest string s, and assume s << n, we can disregard the embedded sort's time complexity of O(n * s * log(s)) because O(n * log(n)) is the dominant term?
    – UnknownBeef
    Dec 28 '18 at 18:41










  • Are you referring to line 4? If so, since we are sorting an array of size s, isn't that an O(s * log(s)) operation each time?
    – UnknownBeef
    Dec 29 '18 at 6:07










  • I meant that O(n * log(n) * s * log(s)) = O(n * s * log(n)), not O(n * s * log(s)).
    – meowgoesthedog
    Dec 29 '18 at 9:37








1




1




The embedded sort call's time complexity depends on the lengths of the strings, not the number of strings (n). The author has probably assumed this to be small.
– meowgoesthedog
Dec 28 '18 at 9:23




The embedded sort call's time complexity depends on the lengths of the strings, not the number of strings (n). The author has probably assumed this to be small.
– meowgoesthedog
Dec 28 '18 at 9:23












So, if we call the size of the biggest string s, and assume s << n, we can disregard the embedded sort's time complexity of O(n * s * log(s)) because O(n * log(n)) is the dominant term?
– UnknownBeef
Dec 28 '18 at 18:41




So, if we call the size of the biggest string s, and assume s << n, we can disregard the embedded sort's time complexity of O(n * s * log(s)) because O(n * log(n)) is the dominant term?
– UnknownBeef
Dec 28 '18 at 18:41












Are you referring to line 4? If so, since we are sorting an array of size s, isn't that an O(s * log(s)) operation each time?
– UnknownBeef
Dec 29 '18 at 6:07




Are you referring to line 4? If so, since we are sorting an array of size s, isn't that an O(s * log(s)) operation each time?
– UnknownBeef
Dec 29 '18 at 6:07












I meant that O(n * log(n) * s * log(s)) = O(n * s * log(n)), not O(n * s * log(s)).
– meowgoesthedog
Dec 29 '18 at 9:37




I meant that O(n * log(n) * s * log(s)) = O(n * s * log(n)), not O(n * s * log(s)).
– meowgoesthedog
Dec 29 '18 at 9:37












0






active

oldest

votes











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53953220%2ftime-complexity-of-this-code-from-cracking-the-coding-interview-group-anagrams%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes
















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.





Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


Please pay close attention to the following guidance:


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53953220%2ftime-complexity-of-this-code-from-cracking-the-coding-interview-group-anagrams%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







GqZN21nY7,ECQSj3haGX4
xxS1QJwN,vcKbNjtrEUK,8pk2k0K 7oTJ2ZNkdL3Zd8z0m4G5IUYCdz

Popular posts from this blog

Monofisismo

compose and upload a new article using a custom form

“attempting to read past stream EOM” using Sybase.AdoNet4.AseClient