PHP - ZipArchive close returns true despite no files being added
0
I have the following code to create a zip archive. How can I check if the archive was actually created?
When no files are added calling close still returns true?
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
}
$res = $zip->close();
if ($res == true) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
}
php laravel ziparchive
asked Jan 2 at 16:45
adam78adam78
2,82073585
add a comment |
0
I have the following code to create a zip archive. How can I check if the archive was actually created?
When no files are added calling close still returns true?
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
}
$res = $zip->close();
if ($res == true) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
}
php laravel ziparchive
asked Jan 2 at 16:45
adam78adam78
2,82073585
add a comment |
0
0
0
I have the following code to create a zip archive. How can I check if the archive was actually created?
When no files are added calling close still returns true?
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
}
$res = $zip->close();
if ($res == true) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
}
php laravel ziparchive
asked Jan 2 at 16:45
adam78adam78
2,82073585
I have the following code to create a zip archive. How can I check if the archive was actually created?
When no files are added calling close still returns true?
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
}
$res = $zip->close();
if ($res == true) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
}
php laravel ziparchive
php laravel ziparchive
asked Jan 2 at 16:45
adam78adam78
2,82073585
asked Jan 2 at 16:45
adam78adam78
2,82073585
edited Jan 2 at 17:01
adam78
asked Jan 2 at 16:45
adam78adam78
2,82073585
asked Jan 2 at 16:45
adam78adam78
2,82073585
asked Jan 2 at 16:45
adam78adam78
2,82073585
2,82073585
add a comment |
add a comment |
2 Answers
2
active
oldest
votes
0
I've simply had to refactor the code as follows to get it to work:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
}
$zip->close();
}
if (file_exists($filePath)) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
answered Jan 2 at 17:02
adam78adam78
2,82073585
add a comment |
0
Each zip operation will return a boolean if it works so you need to check all of them:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
$res = true;
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$res = $res && $zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
else
$res = false;
}
$res = $res && $zip->close();
if ($res == true) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
}
answered Jan 2 at 17:05
apokryfosapokryfos
19.5k53364
this won't work because$resis always true if no files are added.
– adam78
Jan 2 at 17:22
You're right I forgot to include the case where the file didn't exist
– apokryfos
Jan 2 at 19:29
add a comment |
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54010091%2fphp-ziparchive-close-returns-true-despite-no-files-being-added%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
0
I've simply had to refactor the code as follows to get it to work:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
}
$zip->close();
}
if (file_exists($filePath)) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
answered Jan 2 at 17:02
adam78adam78
2,82073585
add a comment |
0
I've simply had to refactor the code as follows to get it to work:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
}
$zip->close();
}
if (file_exists($filePath)) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
answered Jan 2 at 17:02
adam78adam78
2,82073585
add a comment |
0
0
0
I've simply had to refactor the code as follows to get it to work:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
}
$zip->close();
}
if (file_exists($filePath)) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
answered Jan 2 at 17:02
adam78adam78
2,82073585
I've simply had to refactor the code as follows to get it to work:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
}
$zip->close();
}
if (file_exists($filePath)) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
answered Jan 2 at 17:02
adam78adam78
2,82073585
answered Jan 2 at 17:02
adam78adam78
2,82073585
answered Jan 2 at 17:02
adam78adam78
2,82073585
answered Jan 2 at 17:02
adam78adam78
2,82073585
2,82073585
add a comment |
add a comment |
0
Each zip operation will return a boolean if it works so you need to check all of them:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
$res = true;
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$res = $res && $zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
else
$res = false;
}
$res = $res && $zip->close();
if ($res == true) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
}
answered Jan 2 at 17:05
apokryfosapokryfos
19.5k53364
this won't work because$resis always true if no files are added.
– adam78
Jan 2 at 17:22
You're right I forgot to include the case where the file didn't exist
– apokryfos
Jan 2 at 19:29
add a comment |
0
Each zip operation will return a boolean if it works so you need to check all of them:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
$res = true;
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$res = $res && $zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
else
$res = false;
}
$res = $res && $zip->close();
if ($res == true) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
}
answered Jan 2 at 17:05
apokryfosapokryfos
19.5k53364
this won't work because$resis always true if no files are added.
– adam78
Jan 2 at 17:22
You're right I forgot to include the case where the file didn't exist
– apokryfos
Jan 2 at 19:29
add a comment |
0
0
0
Each zip operation will return a boolean if it works so you need to check all of them:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
$res = true;
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$res = $res && $zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
else
$res = false;
}
$res = $res && $zip->close();
if ($res == true) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
}
answered Jan 2 at 17:05
apokryfosapokryfos
19.5k53364
Each zip operation will return a boolean if it works so you need to check all of them:
$profiles = $profileRepository->getProfiles()->get();
$fileName = time() . '-' . uniqid() . '-' . '.zip';
$filePath = storage_path('app/bulkdownloads/' . $fileName);
$zip = new ZipArchive;
if ($zip->open($filePath, ZipArchive::CREATE) === TRUE) {
$res = true;
foreach($profiles as $profile) {
if (file_exists(storage_path('app/' . $profile->file_path)))
$res = $res && $zip->addFile(storage_path('app/' . $profile->file_path), $profile->name . '-' . $profile->id . '.' . pathinfo($profile->file_path, PATHINFO_EXTENSION));
else
$res = false;
}
$res = $res && $zip->close();
if ($res == true) {
$newFile = AppFile::create([
"name" => $fileName
"path" => 'bulkdownloads/' . $fileName,
"size" => filesize($filePath),
"mime_type" => mime_content_type($filePath),
]);
}
}
answered Jan 2 at 17:05
apokryfosapokryfos
19.5k53364
edited Jan 2 at 19:29
answered Jan 2 at 17:05
apokryfosapokryfos
19.5k53364
answered Jan 2 at 17:05
apokryfosapokryfos
19.5k53364
answered Jan 2 at 17:05
apokryfosapokryfos
19.5k53364
19.5k53364
this won't work because$resis always true if no files are added.
– adam78
Jan 2 at 17:22
You're right I forgot to include the case where the file didn't exist
– apokryfos
Jan 2 at 19:29
add a comment |
this won't work because$resis always true if no files are added.
– adam78
Jan 2 at 17:22
You're right I forgot to include the case where the file didn't exist
– apokryfos
Jan 2 at 19:29
this won't work because
$res is always true if no files are added.– adam78
Jan 2 at 17:22
this won't work because
$res is always true if no files are added.– adam78
Jan 2 at 17:22
You're right I forgot to include the case where the file didn't exist
– apokryfos
Jan 2 at 19:29
You're right I forgot to include the case where the file didn't exist
– apokryfos
Jan 2 at 19:29
add a comment |
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f54010091%2fphp-ziparchive-close-returns-true-despite-no-files-being-added%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
